chore(symfony): deprecations #6401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Jun 1, 2024
| * | ||
| * @internal | ||
| */ | ||
| final class PropertyInfoToTypeInfoHelper |
There was a problem hiding this comment.
I think this is good enough for now, but in the future we should migrate to use the new type class by default and convert it to the legacy type instead of the other way. This will likely improve performance, and will ease the maintenance.
There was a problem hiding this comment.
yes but while its experimental this is a good solution, also I don't really know why the Doctrine Extractor (MongoDB) is the only one impacted, there must be something in Symfony that doesn't cover the bc layer.
| @@ -25,3 +25,4 @@ | |||
| %ApiPlatform\\Api\\FilterInterface is deprecated in favor of ApiPlatform\\Metadata\\FilterInterface% | |||
|
|
|||
| %The "Symfony\\Bundle\\MakerBundle\\Maker\\MakeAuthenticator" class is deprecated, use any of the Security\\Make\* commands instead% | |||
| %Since symfony/validator 7.1: Not passing a value for the "requireTld" option to the Url constraint is deprecated. Its default value will change to "true".% | |||
There was a problem hiding this comment.
nit: we could pass the value explicitly instead?
There was a problem hiding this comment.
not really:
- it's only in our tests
- we need to find a way to know if the option exists
- the default value is fine for us (as not really used by us)
therefore it won't break when updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.