fix(laravel): entrypoint serialization #6541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
commented
Aug 22, 2024
| @@ -37,13 +37,13 @@ public function __construct( | |||
| private readonly ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory, | |||
There was a problem hiding this comment.
By the way, this class should probably be undeprecated as it is now used again.
There was a problem hiding this comment.
Shouldn't we just copy that class to the Laravel directory?
dunglas
commented
Aug 22, 2024
| @@ -37,13 +37,13 @@ public function __construct( | |||
| private readonly ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory, | |||
| private readonly ProviderInterface $provider, | |||
| private readonly ProcessorInterface $processor, | |||
| private readonly array $documentationFormats = [] | |||
| private readonly array $documentationFormats = [], | |||
There was a problem hiding this comment.
This is likely a bug in Symfony variant. AFAIU, formats should be injected here, not docs_formats.
There was a problem hiding this comment.
indeed both implementation are not necessary the same
There was a problem hiding this comment.
Laravel has no differenciation between both formats yet?
There was a problem hiding this comment.
That would be cool to be able to render SwaggerUI when requesting /api as we do for the Symfony variant.
dunglas
force-pushed
the
fix/entrypoint-serialization
branch
from
7f29f81
to
bd251c4
Compare
dunglas
force-pushed
the
fix/entrypoint-serialization
branch
from
bd251c4
to
d50abd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
jsonapiformat weren't working. This patch fixes the issue.