Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overwriting XML ApiResource definition by YAML ApiResource definition #6660

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

GSadee
Copy link
Contributor

@GSadee GSadee commented Sep 23, 2024

Q A
Branch? 3.4
Tickets fixes #6619
License MIT
Doc PR

In case the same ApiResource is defined in both XML and YAML, this PR makes the ApiResource defined in YAML add itself as another one instead of overwriting the existing one defined in XML.

@soyuka
Copy link
Member

soyuka commented Sep 23, 2024

Shouldn't your target 3.4 ?

@GSadee GSadee changed the base branch from main to 3.4 September 24, 2024 07:34
@GSadee
Copy link
Contributor Author

GSadee commented Sep 24, 2024

Shouldn't your target 3.4 ?

Yes, it should, my mistake when opening PR, I changed the base branch as this branch is already rebased with 3.4 👌🏻

@soyuka soyuka merged commit b93ee46 into api-platform:3.4 Oct 4, 2024
56 of 59 checks passed
@soyuka
Copy link
Member

soyuka commented Oct 4, 2024

Thanks!

@GSadee GSadee deleted the fix-adding-api-resources branch October 4, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YAML ApiResource configuration overwrites XML ApiResource
2 participants