fix: using parameters in fromClass and toClass uriVariables' options #6663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Sep 23, 2024
GSadee
force-pushed
the
fix-resolve-parameters-in-uri-variables
branch
from
407163b
to
6d2ca3e
Compare
|
May you target 3.4 instead? |
Yes, it should, my mistake when opening PR, I changed the base branch as this branch is already rebased with 3.4 👌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no possibility to pass the class as a parameter in
fromClassandtoClassuriVariables' options and this PR adds this missed possibility.