test(laravel): call factories, debug is now false by default #6702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
shouldSeed(orchestral/testbench-core@57954cc) is now false by default we didn't executed the DatabaseSeeder every time. I choose to load just what we need for each test to speed up tests. Also, I noted that we may have side effects using the file storage asapp.debuglooks to befalseby default for testing (not sure what brought this update) and therefore when adding a format inside tests we need to use the MemoryCache, or to clear laravel's cache (couldn't make it work through the workbench command).