feat(metadata/doctrine): Use Type of TypeInfo instead of PropertyInfo

[mtarld]

Q	A
Branch?	main
Tickets
License	MIT
Doc PR

In order to anticipate the deprecation of PropertyInfo's Type in favor of TypeInfo's one, this PR adds a new property phpType (the name can be challenged) that will aim to replace builtinTypes.

What has been done:

• Add ApiProperty::$phpType property, ApiProperty::getPhpType(), and ApiProperty::withPhpType().
• Add PropertyInfoToTypeInfoHelper::convertTypeToLegacyTypes to store legacy types in ApiProperty::$builtinTypes when setting ApiProperty::$phpType, this allows API Platform to work "the legacy way" while upgrading other packages.
• Doesn't trigger deprecations yet in ApiProperty to allow other API Platform packages to upgrade first.
• Update AbstractItemNormalizer to not be dependent on the type order (type order might not be the same with these changes)
• Implement PropertyTypeExtractorInterface::getType() in DoctrineExtractor (as getTypes is deprecated)
• Bump api-platform/metadata to ^4.1, symfony/property-info to ^7.1 in all packages
• Require symfony/type-info:^7.2 in api-platform/metadata and api-platform/doctrine

[mtarld]

For information, the code can become simpler if the following PRs get merged:

symfony/symfony#59844 will update

$typeIsResourceClass = function (Type $type) use (&$typeIsResourceClass): bool {
    return match (true) {
        $type instanceof CollectionType => $type->getCollectionValueType()->isSatisfiedBy($typeIsResourceClass),
        $type instanceof WrappingTypeInterface => $type->wrappedTypeIsSatisfiedBy($typeIsResourceClass),
        $type instanceof CompositeTypeInterface => $type->composedTypesAreSatisfiedBy($typeIsResourceClass),
        default => $type instanceof ObjectType && $this->isResourceClass($type->getClassName()),
    };
};

to

$typeIsResourceClass = fn (Type $type): bool => $type instanceof ObjectType && $this->isResourceClass($type->getClassName());

symfony/symfony#59845 will update

foreach ($type instanceof CompositeTypeInterface ? $type->getTypes() : [$type] as $t) {
    while ($t instanceof WrappingTypeInterface) {
        $t = $t->getWrappedType();
    }

    $typeStrings[] = (string) $t;
}

to

foreach ($type->traverse() as $t) {
    if ($t instanceof CompositeTypeInterface || $t instanceof WrappingTypeInterface) {
        continue;
    }

    $typeStrings[] = (string) $t;
}

[mtarld]

Anyway, I don't think the deprecation can be triggered before January 2026 (before the EOL of PHP 8.1), so we have plenty of time 🙂

Edit: I was wrong about it, there is no need to wait, the deprecation could be merged in Symfony 7.3

[soyuka]

I'm merging this starting work, we'll continue working towards the main branch based on pull requests on the fork at https://github.com/mtarld/core/pulls. Or else it makes it hard to review properly.

Tests are red for deprecations as we introduced a bunch, no worries the BC layer should be easy enough.
Symfony 7.3 will be out in one month from now, therefore we keep the type-info component in dev mode until the last patches are out, this helps us with patches upstream.

I'll cherry-pick everything by keeping the backward layer, thanks @mtarld for starting this!