fix(symfony): do not load docs routes if docs disabled #7448
Conversation
alexndlm
commented
Oct 8, 2025
alexndlm
commented
| Q | A |
|---|---|
| Branch? | 4.2 |
| Tickets | |
| License | MIT |
| Doc PR |
src/Symfony/Routing/ApiLoader.php
Outdated
| { | ||
| $routeCollection->addCollection($this->fileLoader->load('docs.xml')); | ||
| if ($this->docsEnabled) { | ||
| $routeCollection->addCollection($this->fileLoader->load('docs.xml')); |
There was a problem hiding this comment.
@GromNaN should we also move our routes to php?
There was a problem hiding this comment.
Yes, it need to be done also: symfony/symfony#60568
We should add a 2nd transformation class in https://github.com/GromNaN/symfony-config-xml-to-php
|
We did not do this on purpose a when using JSON-LD you sematically need to have the |
I'm sorry, but I don't think it's a good idea. I also refactored a little, please check. |
|
can you rebase, don't you have a way to disable the open api docs? can you explain a little bit more what you want to disable ? |
alexndlm
force-pushed
the
feature/do-not-load-docs-routes-if-docs-disabled
branch
from
7ff2c24 to
3777747
Compare
|
Rebased. The main goal is not to have a |
3 participants
