fix(symfony): check if required package is installed before configuri… #7607
+33
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaa2000
force-pushed
the
feat-7053-conf-validation
branch
2 times, most recently
from
0c8c3be to
e5f5c89
Compare
…ng associated services
aaa2000
force-pushed
the
feat-7053-conf-validation
branch
4 times, most recently
from
94d540e to
86a632d
Compare
aaa2000
commented
Dec 14, 2025
| "illuminate/support": "^11.0 || ^12.0", | ||
| "jangregor/phpstan-prophecy": "^2.1.11", | ||
| "justinrainbow/json-schema": "^5.2.11", | ||
| "justinrainbow/json-schema": "5.3.0", |
Contributor
Author
There was a problem hiding this comment.
Correct by downgrading the package version of jsonrainbow/json-schema from 5.3.1 to 5.3.0
Strangely, the fix https://github.com/jsonrainbow/json-schema/pull/857/changes caused the errors in the CI. And I couldn't reproduce the problem locally.
aaa2000
force-pushed
the
feat-7053-conf-validation
branch
from
e181ae7 to
111b5a8
Compare
soyuka
reviewed
Dec 15, 2025
soyuka
changed the title
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if required package is installed before configuring associated services.
I haven’t included tests for this change because I’m not sure how to properly test this part of the code
Note: The Behat errors in CI are already present on branch 4.2