fix tests

api/.env.test

@@ -1,7 +1,6 @@
 # define your env variables for the test env here
 KERNEL_CLASS='App\Kernel'
 APP_SECRET='$ecretf0rt3st'
-SYMFONY_DEPRECATIONS_HELPER=999999
 PANTHER_APP_ENV=panther
 PANTHER_ERROR_SCREENSHOT_DIR=./var/error-screenshots
 

api/composer.json

@@ -6,7 +6,7 @@
         "ext-ctype": "*",
         "ext-iconv": "*",
         "ext-xml": "*",
-        "api-platform/core": "dev-main",
+        "api-platform/core": "^3.2@beta",
         "doctrine/doctrine-bundle": "^2.7",
         "doctrine/doctrine-migrations-bundle": "^3.2",
         "doctrine/orm": "^2.12",

api/phpunit.xml.dist

@@ -2,7 +2,7 @@
 
 <!-- https://phpunit.readthedocs.io/en/latest/configuration.html -->
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
+         xsi:noNamespaceSchemaLocation="vendor/bin/.phpunit/phpunit/phpunit.xsd"
          backupGlobals="false"
          colors="true"
          bootstrap="tests/bootstrap.php"

api/src/Entity/Book.php

@@ -35,6 +35,7 @@
 #[ApiResource(
     uriTemplate: '/admin/books{._format}',
     types: ['https://schema.org/Book', 'https://schema.org/Offer'],
+    extraProperties: ['rfc_7807_compliant_errors' => true],
     operations: [
         new GetCollection(
             itemUriTemplate: '/admin/books/{id}{._format}',
@@ -64,11 +65,16 @@
         'groups' => ['Book:read:admin', 'Enum:read'],
         'skip_null_values' => true,
     ],
-    denormalizationContext: ['groups' => ['Book:write']],
+    denormalizationContext: [
+        'groups' => ['Book:write'],
+    ],
+    // todo waiting for https://github.com/api-platform/core/pull/5844
+//    collectDenormalizationErrors: true,
     security: 'is_granted("ROLE_ADMIN")'
 )]
 #[ApiResource(
     types: ['https://schema.org/Book', 'https://schema.org/Offer'],
+    extraProperties: ['rfc_7807_compliant_errors' => true],
     operations: [
         new GetCollection(
             itemUriTemplate: '/books/{id}{._format}'

api/src/Entity/Bookmark.php

@@ -30,6 +30,7 @@
 #[ApiResource(
     types: ['https://schema.org/BookmarkAction'],
     order: ['bookmarkedAt' => 'DESC'],
+    extraProperties: ['rfc_7807_compliant_errors' => true],
     operations: [
         new GetCollection(),
         new Delete(
@@ -46,7 +47,11 @@
             'book' => '/books/{id}{._format}',
         ],
     ],
-    denormalizationContext: ['groups' => ['Bookmark:write']],
+    denormalizationContext: [
+        'groups' => ['Bookmark:write'],
+    ],
+    // todo waiting for https://github.com/api-platform/core/pull/5844
+//    collectDenormalizationErrors: true,
     mercure: true,
     security: 'is_granted("ROLE_USER")'
 )]

api/src/Entity/Review.php

@@ -35,6 +35,7 @@
 #[ApiResource(
     types: ['https://schema.org/Review'],
     order: ['publishedAt' => 'DESC'],
+    extraProperties: ['rfc_7807_compliant_errors' => true],
     operations: [
         new GetCollection(
             uriTemplate: '/admin/reviews{._format}',
@@ -69,12 +70,17 @@
         'skip_null_values' => true,
         'groups' => ['Review:read', 'Review:read:admin'],
     ],
-    denormalizationContext: ['groups' => ['Review:write', 'Review:write:admin']],
+    denormalizationContext: [
+        'groups' => ['Review:write', 'Review:write:admin'],
+    ],
+    // todo waiting for https://github.com/api-platform/core/pull/5844
+//    collectDenormalizationErrors: true,
     security: 'is_granted("ROLE_ADMIN")'
 )]
 #[ApiResource(
     types: ['https://schema.org/Review'],
     order: ['publishedAt' => 'DESC'],
+    extraProperties: ['rfc_7807_compliant_errors' => true],
     uriTemplate: '/books/{bookId}/reviews{._format}',
     uriVariables: [
         'bookId' => new Link(toProperty: 'book', fromClass: Book::class),
@@ -128,7 +134,11 @@
         'skip_null_values' => true,
         'groups' => ['Review:read'],
     ],
-    denormalizationContext: ['groups' => ['Review:write']]
+    denormalizationContext: [
+        'groups' => ['Review:write'],
+    ],
+    // todo waiting for https://github.com/api-platform/core/pull/5844
+//    collectDenormalizationErrors: true
 )]
 #[ORM\Entity(repositoryClass: ReviewRepository::class)]
 #[ORM\UniqueConstraint(fields: ['user', 'book'])]

api/src/Entity/User.php

@@ -23,6 +23,7 @@
  */
 #[ApiResource(
     types: ['https://schema.org/Person'],
+    extraProperties: ['rfc_7807_compliant_errors' => true],
     operations: [
         new GetCollection(
             uriTemplate: '/admin/users{._format}',

api/src/State/Processor/MercureProcessor.php

@@ -34,7 +34,7 @@ public function __construct(
      * @throws ResourceClassNotFoundException
      * @throws RuntimeException
      */
-    public function process(mixed $data, Operation $operation, array $uriVariables = [], array $context = [])
+    public function process(mixed $data, Operation $operation, array $uriVariables = [], array $context = []): mixed
     {
         if (isset($context['item_uri_template'])) {
             $operation = $this->resourceMetadataCollectionFactory->create($data::class)->getOperation($context['item_uri_template']);

api/tests/Api/Admin/BookTest.php

@@ -52,6 +52,7 @@ public function testAsNonAdminUserICannotGetACollectionOfBooks(int $expectedCode
 
         self::assertResponseStatusCodeSame($expectedCode);
         self::assertResponseHeaderSame('content-type', 'application/problem+json; charset=utf-8');
+        self::assertResponseHeaderSame('link', '<http://www.w3.org/ns/hydra/error>; rel="http://www.w3.org/ns/json-ld#error",<http://localhost/docs.jsonld>; rel="http://www.w3.org/ns/hydra/core#apiDocumentation"');
         self::assertJsonContains([
             '@context' => '/contexts/Error',
             '@type' => 'hydra:Error',
@@ -194,6 +195,7 @@ public function testAsNonAdminUserICannotGetABook(int $expectedCode, string $hyd
 
         self::assertResponseStatusCodeSame($expectedCode);
         self::assertResponseHeaderSame('content-type', 'application/problem+json; charset=utf-8');
+        self::assertResponseHeaderSame('link', '<http://www.w3.org/ns/hydra/error>; rel="http://www.w3.org/ns/json-ld#error",<http://localhost/docs.jsonld>; rel="http://www.w3.org/ns/hydra/core#apiDocumentation"');
         self::assertJsonContains([
             '@context' => '/contexts/Error',
             '@type' => 'hydra:Error',
@@ -249,6 +251,7 @@ public function testAsNonAdminUserICannotCreateABook(int $expectedCode, string $
 
         self::assertResponseStatusCodeSame($expectedCode);
         self::assertResponseHeaderSame('content-type', 'application/problem+json; charset=utf-8');
+        self::assertResponseHeaderSame('link', '<http://www.w3.org/ns/hydra/error>; rel="http://www.w3.org/ns/json-ld#error",<http://localhost/docs.jsonld>; rel="http://www.w3.org/ns/hydra/core#apiDocumentation"');
         self::assertJsonContains([
             '@context' => '/contexts/Error',
             '@type' => 'hydra:Error',
@@ -272,7 +275,8 @@ public function testAsAdminUserICannotCreateABookWithInvalidData(array $data, in
         ]);
 
         self::assertResponseStatusCodeSame($statusCode);
-        self::assertResponseHeaderSame('content-type', 'application/ld+json; charset=utf-8');
+        self::assertResponseHeaderSame('content-type', 'application/problem+json; charset=utf-8');
+        self::assertResponseHeaderSame('link', '<http://www.w3.org/ns/hydra/error>; rel="http://www.w3.org/ns/json-ld#error",<http://localhost/docs.jsonld>; rel="http://www.w3.org/ns/hydra/core#apiDocumentation"');
         self::assertJsonContains($expected);
     }
 
@@ -302,32 +306,62 @@ public function getInvalidDataOnCreate(): iterable
 
     public function getInvalidData(): iterable
     {
-//        yield 'empty data' => [
-//            [
-//                'book' => '',
-//                'condition' => '',
-//            ],
-//            Response::HTTP_BAD_REQUEST,
-//            [
-//                '@context' => '/contexts/Error',
-//                '@type' => 'hydra:Error',
+        yield 'empty data' => [
+            [
+                'book' => '',
+                'condition' => '',
+            ],
+            Response::HTTP_BAD_REQUEST,
+            // todo waiting for https://github.com/api-platform/core/pull/5844
+//            Response::HTTP_UNPROCESSABLE_ENTITY,
+            [
+                '@context' => '/contexts/Error',
+                '@type' => 'hydra:Error',
+                'hydra:title' => 'An error occurred',
+                'hydra:description' => 'The data must belong to a backed enumeration of type '.BookCondition::class,
+                // todo waiting for https://github.com/api-platform/core/pull/5844[
+//                '@context' => '/contexts/ConstraintViolationList',
+//                '@type' => 'ConstraintViolationList',
 //                'hydra:title' => 'An error occurred',
-//                'hydra:description' => 'The data must belong to a backed enumeration of type '.BookCondition::class,
-//            ],
-//        ];
-//        yield 'invalid condition' => [
-//            [
-//                'book' => 'https://openlibrary.org/books/OL28346544M.json',
-//                'condition' => 'invalid condition',
-//            ],
-//            Response::HTTP_BAD_REQUEST,
-//            [
-//                '@context' => '/contexts/Error',
-//                '@type' => 'hydra:Error',
+//                'hydra:description' => 'book: This value should not be blank.\ncondition: This value should be of type '.BookCondition::class.'.',
+//                'violations' => [
+//                    [
+//                        'propertyPath' => 'book',
+//                        'hint' => 'This value should not be blank.',
+//                    ],
+//                    [
+//                        'propertyPath' => 'condition',
+//                        'hint' => 'The data must belong to a backed enumeration of type '.BookCondition::class,
+//                    ],
+//                ],
+            ],
+        ];
+        yield 'invalid condition' => [
+            [
+                'book' => 'https://openlibrary.org/books/OL28346544M.json',
+                'condition' => 'invalid condition',
+            ],
+            Response::HTTP_BAD_REQUEST,
+            // todo waiting for https://github.com/api-platform/core/pull/5844
+//            Response::HTTP_UNPROCESSABLE_ENTITY,
+            [
+                '@context' => '/contexts/Error',
+                '@type' => 'hydra:Error',
+                'hydra:title' => 'An error occurred',
+                'hydra:description' => 'The data must belong to a backed enumeration of type '.BookCondition::class,
+                // todo waiting for https://github.com/api-platform/core/pull/5844
+//                '@context' => '/contexts/ConstraintViolationList',
+//                '@type' => 'ConstraintViolationList',
 //                'hydra:title' => 'An error occurred',
-//                'hydra:description' => 'The data must belong to a backed enumeration of type '.BookCondition::class,
-//            ],
-//        ];
+//                'hydra:description' => 'condition: This value should be of type '.BookCondition::class.'.',
+//                'violations' => [
+//                    [
+//                        'propertyPath' => 'condition',
+//                        'hint' => 'The data must belong to a backed enumeration of type '.BookCondition::class,
+//                    ],
+//                ],
+            ],
+        ];
         yield 'invalid book' => [
             [
                 'book' => 'invalid book',
@@ -427,6 +461,7 @@ public function testAsNonAdminUserICannotUpdateBook(int $expectedCode, string $h
 
         self::assertResponseStatusCodeSame($expectedCode);
         self::assertResponseHeaderSame('content-type', 'application/problem+json; charset=utf-8');
+        self::assertResponseHeaderSame('link', '<http://www.w3.org/ns/hydra/error>; rel="http://www.w3.org/ns/json-ld#error",<http://localhost/docs.jsonld>; rel="http://www.w3.org/ns/hydra/core#apiDocumentation"');
         self::assertJsonContains([
             '@context' => '/contexts/Error',
             '@type' => 'hydra:Error',
@@ -470,7 +505,8 @@ public function testAsAdminUserICannotUpdateABookWithInvalidData(array $data, in
         ]);
 
         self::assertResponseStatusCodeSame($statusCode);
-        self::assertResponseHeaderSame('content-type', 'application/ld+json; charset=utf-8');
+        self::assertResponseHeaderSame('content-type', 'application/problem+json; charset=utf-8');
+        self::assertResponseHeaderSame('link', '<http://www.w3.org/ns/hydra/error>; rel="http://www.w3.org/ns/json-ld#error",<http://localhost/docs.jsonld>; rel="http://www.w3.org/ns/hydra/core#apiDocumentation"');
         self::assertJsonContains($expected);
     }
 
@@ -553,6 +589,7 @@ public function testAsNonAdminUserICannotDeleteABook(int $expectedCode, string $
 
         self::assertResponseStatusCodeSame($expectedCode);
         self::assertResponseHeaderSame('content-type', 'application/problem+json; charset=utf-8');
+        self::assertResponseHeaderSame('link', '<http://www.w3.org/ns/hydra/error>; rel="http://www.w3.org/ns/json-ld#error",<http://localhost/docs.jsonld>; rel="http://www.w3.org/ns/hydra/core#apiDocumentation"');
         self::assertJsonContains([
             '@context' => '/contexts/Error',
             '@type' => 'hydra:Error',