fix: remove grpc-client-nginx-module #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
|
|
For all the CI, this step of updating and installing tools failed :
|
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
|
We should make the ci pass |
starsz
reviewed
Feb 20, 2024
starsz
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In APISIX, a Golang library was previously used to effectively implement a gRPC client and bind it to the Nginx ecosystem. It is called grpc-client-nginx-module. APISIX no longer uses this, it was removed in the PR apache/apisix#9456. This PR removes it from the build-tools