feat: support pass cert and priv key content #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
AlinsRan
approved these changes
Aug 28, 2023
| + if type(client_cert_path) ~= "string" then | ||
| + error("bad client_cert option type", 2) | ||
| + if options.client_priv_key_path and options.client_priv_key then | ||
| + error("client certificate private key supplied with " .. |
There was a problem hiding this comment.
The error message is somewhat ambiguous.
It should be noted that: Only one of the parameters 'a' and 'b' can be set
WDYT?
There was a problem hiding this comment.
APISIX's ci checks the error message format returned by this function.
leslie-tsang
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested this PR at https://github.com/Sn0rt/apisix/pull/4