Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): add missing deps lrexlib-pcre for rockspec #76

Merged

Conversation

leslie-tsang
Copy link
Contributor

fix rex_pcre.so not found when loading rex_pcre module

Copy link
Contributor

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leslie-tsang
Copy link
Contributor Author

We should update https://github.com/api7/jsonschema#installation

I'm not sure what should be updated.

If you were using the LuaJIT of OpenResty, it will use the built-in ngx.re.find automatically. But if you are using Lua 5.2, 5.3 or LuaJIT 2.1 beta, you will need to install lrexlib-pcre.

As Installation section has declare the dependencies.

When we exec the install command, it will automatically install dependencies via luarocks.

luarocks install jsonschema

@spacewander
Copy link
Contributor

We should update api7/jsonschema#installation

I'm not sure what should be updated.

If you were using the LuaJIT of OpenResty, it will use the built-in ngx.re.find automatically. But if you are using Lua 5.2, 5.3 or LuaJIT 2.1 beta, you will need to install lrexlib-pcre.

As Installation section has declare the dependencies.

When we exec the install command, it will automatically install dependencies via luarocks.

luarocks install jsonschema

Now lrexlib-pcre is handled automatically too.

@leslie-tsang
Copy link
Contributor Author

@spacewander ping

@spacewander spacewander merged commit d2dd949 into api7:master Feb 18, 2022
@spacewander
Copy link
Contributor

@leslie-tsang
Please create a new version for it.

@leslie-tsang leslie-tsang deleted the bugfix/add-missing-deps-for-rockspec branch February 18, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants