Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions for LookupArgumentSets #21

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add descriptions for LookupArgumentSets #21

merged 1 commit into from
Nov 17, 2023

Conversation

paulsturgess
Copy link
Contributor

@paulsturgess paulsturgess commented Nov 17, 2023

OpenAPI 3.0 does not support parameter dependencies and mutually exclusive parameters.

https://swagger.io/docs/specification/describing-parameters/#dependencies

This is a complex topic with a lot of debate:
OAI/OpenAPI-Specification#256

We know that our LookupArgumentSets are mutually exclusive, so the best thing is to add a description explaining this, so that it will appear in documentation and tools like the swagger editor.

Apia already returns a 400 with a friendly error message.

closes: #4

Swagger GET:
Screenshot 2023-11-17 at 11 21 43

Swagger POST:
Screenshot 2023-11-17 at 11 21 28

OpenAPI 3.0 does not support parameter dependencies and mutually exclusive parameters.

https://swagger.io/docs/specification/describing-parameters/#dependencies

This is a complex topic with a lot of debate:
OAI/OpenAPI-Specification#256

We know that our LookupArgumentSets are mutually exclusive, so the best thing is to
add a description explaining this, so that it will appear in documentation and tools like the swagger editor.

Apia already returns a 400 with a friendly error message.

closes: #4
@paulsturgess paulsturgess marked this pull request as ready for review November 17, 2023 11:21
@paulsturgess paulsturgess self-assigned this Nov 17, 2023
@paulsturgess paulsturgess merged commit 85d1bc6 into main Nov 17, 2023
@paulsturgess paulsturgess deleted the 4-arg-sets branch November 17, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve how LookupArgumentSets are defined
1 participant