Skip to content
This repository was archived by the owner on Nov 8, 2024. It is now read-only.

Conversation

lulco
Copy link
Contributor

@lulco lulco commented Feb 12, 2019

Added support for example in parameters:

      parameters:
        -
          name: code
          in: query
          required: true
          description: 'Code to check'
          example: ABCDEFG
          schema:
            type: string

Not working with

      parameters:
        -
          name: code
          in: query
          required: true
          description: 'Code to check'
          schema:
            type: string
            example: ABCDEFG

yet.

This helps me to (partially) resolve issue apiaryio/dredd#1236

Not sure, if this is correct, it is my first contribution. So please, feel free to correct my code.

tjanc added a commit that referenced this pull request Feb 13, 2019
tjanc added a commit that referenced this pull request Feb 13, 2019
tjanc
tjanc previously requested changes Feb 13, 2019
Copy link
Contributor

@tjanc tjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lulco !
I've generalized your solution based on my review: tjanc/parameter-example. You can either modify your PR to match this (so you rightfully have your name on those commits ;) ), or we can make a PR out of my branch. I will leave that up to you.

Copy link
Contributor

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor changes needed. Also, can you squash all your commits into a single commit and then write it's message such a way that the commitlint doesn't complain? Thanks.

@lulco
Copy link
Contributor Author

lulco commented Feb 14, 2019

@tjanc sorry, I somehow skip the message you wrote about your branch. Can I copy some of your tests (I miss array and object examples). Or we can create MR from your branch, I don't care about my name in commits :) just want to help to improve this project

@tjanc
Copy link
Contributor

tjanc commented Feb 14, 2019

@lulco I would test array and object for completeness' sake. You can copy the ones from my branch, of course. Also, can you please modify your commit message from chore(oas3): ... to feat(oas3): ...? You are adding a feature to the parser ;) After that it's good to be merged from my side.

@lulco
Copy link
Contributor Author

lulco commented Feb 15, 2019

@tjanc @pksunkara I think I'm done, can you please make last check and merge?

@kylef kylef added the openapi3 label Feb 18, 2019
@pksunkara pksunkara merged commit c63b525 into apiaryio:master Feb 19, 2019
@honzajavorek
Copy link
Contributor

@lulco Thanks 👏 🙇

@YosaRama
Copy link

Hi there, any update for able to used schema.example ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants