-
Notifications
You must be signed in to change notification settings - Fork 18
Added partial support for the example
in Parameter Object
#156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lulco !
I've generalized your solution based on my review: tjanc/parameter-example. You can either modify your PR to match this (so you rightfully have your name on those commits ;) ), or we can make a PR out of my branch. I will leave that up to you.
packages/fury-adapter-oas3-parser/lib/parser/oas/parseParameterObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseParameterObject-test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor changes needed. Also, can you squash all your commits into a single commit and then write it's message such a way that the commitlint doesn't complain? Thanks.
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseParameterObject-test.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseParameterObject-test.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseParameterObject-test.js
Outdated
Show resolved
Hide resolved
@tjanc sorry, I somehow skip the message you wrote about your branch. Can I copy some of your tests (I miss array and object examples). Or we can create MR from your branch, I don't care about my name in commits :) just want to help to improve this project |
@lulco I would test |
@tjanc @pksunkara I think I'm done, can you please make last check and merge? |
@lulco Thanks 👏 🙇 |
Hi there, any update for able to used |
Added support for
example
in parameters:Not working with
yet.
This helps me to (partially) resolve issue apiaryio/dredd#1236
Not sure, if this is correct, it is my first contribution. So please, feel free to correct my code.