APIB Serializer

[pksunkara]

Fixes #33

[kylef]

@pksunkara why did you make these closures instead of functions?

[pksunkara]

Because we are exporting these in this module. I generally use the rule that if I am exporting functions in ES6, I make them closures

[kylef]

This brings inconsistency, against both other packages we maintain and even other files in the same package (function getTypeAttributes(element, attributes, parent) { a few lines down). That said, I believe it should be a named function for numerous reasons, due to scoping, hoisting, and transferring of this. Our style guide is also clear on this, it should be a named function instead of a function declaration:

7.1:

• 7.1 Use named function expressions instead of function declarations. eslint: func-style

  Why? Function declarations are hoisted, which means that it’s easy - too easy - to reference the function before it is defined in the file. This harms readability and maintainability. If you find that a function’s definition is large or complex enough that it is interfering with understanding the rest of the file, then perhaps it’s time to extract it to its own module! Don’t forget to explicitly name the expression, regardless of whether or not the name is inferred from the containing variable (which is often the case in modern browsers or when using compilers such as Babel). This eliminates any assumptions made about the Error’s call stack. (Discussion)

  // bad
  function foo() {
    // ...
  }
  
  // bad
  const foo = function () {
    // ...
  };
  
  // good
  // lexical name distinguished from the variable-referenced invocation(s)
  const short = function longUniqueMoreDescriptiveLexicalFoo() {
    // ...
  };

Arrow functions are function expressions instead of named functions. You cannot declare a named arrow function.

[pksunkara]

I have been doing this for other packages in the monorepo. I will make a separate PR standardizing this once this is merged.