Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Commit

Permalink
refactor: adds links to github issues of todo notes
Browse files Browse the repository at this point in the history
  • Loading branch information
artem-zakharchenko committed Apr 30, 2019
1 parent 0ca5ba3 commit d97489f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
14 changes: 7 additions & 7 deletions lib/configuration/applyConfiguration.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ const normalizeConfig = require('./normalizeConfig');
const DEFAULT_CONFIG = {
http: {},
endpoint: null,
// TODO Find a way to deep merge default and custom configs
// while presering prototypes.
// When the next line is uncommented, "emitter" property will be processed
// during "R.mergeDeepX" call, resulting into EventEmitter's instance prototype
// not being copied. This breaks event emitter.
/**
* @todo https://github.com/apiaryio/dredd/issues/1345
* When the next line is uncommented, "emitter" property will be processed
* during "R.mergeDeepX" call, resulting into EventEmitter's instance prototype
* not being copied. This breaks event emitter.
*/
// emitter: new EventEmitter(),
custom: {
cwd: process.cwd(),
Expand Down Expand Up @@ -50,8 +51,7 @@ const DEFAULT_CONFIG = {
* Flattens given configuration Object, removing nested "options" key.
* This makes it possible to use nested "options" key without introducing
* a breaking change to the library's public API.
* TODO Remove this method after "options" key is removed in the next
* major version. Document the removal of "options" in the Dredd docs.
* @todo https://github.com/apiaryio/dredd/issues/1344
*/
function flattenConfig(config) {
const proxiedConfig = R.compose(
Expand Down
5 changes: 3 additions & 2 deletions lib/configuration/applyLoggingOptions.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ function applyLoggingOptions(config) {
reporterOutputLogger.transports.console.colorize = false;
}

// Handling the 'loglevel' value
// TODO Can use "applySpec" here to produce next options?
/**
* @todo https://github.com/apiaryio/dredd/issues/1346
*/
if (config.loglevel) {
const loglevel = config.loglevel.toLowerCase();
if (loglevel === 'silent') {
Expand Down

0 comments on commit d97489f

Please sign in to comment.