Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Support for node v4 and v5 #292

Closed
justinabrahms opened this issue Nov 6, 2015 · 12 comments
Closed

Support for node v4 and v5 #292

justinabrahms opened this issue Nov 6, 2015 · 12 comments

Comments

@justinabrahms
Copy link

The README suggests that support for node v4 is coming soon. Nodesource, the folks who release node for ubuntu, don't have a package for nodes before 4.x for the latest ubuntu (15.10) which was released a few weeks ago. (Issue at nodesource/distributions#167)

What's the status of this? What needs to happen? Any chance that this can happen soon?

@dmtrs
Copy link

dmtrs commented Nov 7, 2015

+1

@w-vi
Copy link
Contributor

w-vi commented Nov 9, 2015

We have to fix our protagonist dependency, which I am going to work on now. Dredd for v4.x should be out in 2-3 weeks, depends on how much bugs we encounter on the way.

@dignifiedquire
Copy link

I just checked and protagonist installs fine on node@4.0, but I do not see it as a dependency in package.json. So what exactly is the issue here?

@ddelnano
Copy link
Contributor

I believe the issue is here

@chrisse27
Copy link

+1

2 similar comments
@runk
Copy link

runk commented Nov 30, 2015

+1

@bchew
Copy link

bchew commented Nov 30, 2015

+1

@w-vi
Copy link
Contributor

w-vi commented Nov 30, 2015

Just to clarify what's missing. We need protagonist to generate JSON Schema and that's the bit I'm now working on, basic stuff is already working, now figuring out the edge cases and darker corners of both, MSON and JSON Schema, specs

@clems71
Copy link

clems71 commented Dec 1, 2015

+1

@kylef kylef changed the title Support for node v4.X Support for node v4 and v5 Dec 9, 2015
@w-vi
Copy link
Contributor

w-vi commented Dec 16, 2015

Just merged the #309 so it should work on node v4 and v5 not properly tested yet but if somebody wants to give it a shot from master feel free. Travis test will get updated soon to test for those as well. Once that is done and npm package released I will close this one.

@honzajavorek
Copy link
Contributor

Since today we're testing Dredd on both v4 and v5 (see #310) and tests are passing. I think we can consider this to be done and if there are any particular problems found when using these Node.js versions, let's create individual issues for them. Thanks everyone! 🎈

@dignifiedquire
Copy link

Greatly appreciated! Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants