Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Test with node 4 and 5 #310

Merged
merged 3 commits into from
Dec 17, 2015
Merged

Test with node 4 and 5 #310

merged 3 commits into from
Dec 17, 2015

Conversation

ascripcaru
Copy link
Contributor

No description provided.

@honzajavorek
Copy link
Contributor

This is awesome! Can't wait! 🎁

- ubuntu-toolchain-r-test
packages:
- gcc-4.8
- g++-4.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be better to instead use the trusty image on Travis (https://docs.travis-ci.com/user/trusty-ci-environment/). Since it already has modern compilers it should speed up the CI time and also removes many lines from the .travis.yml file.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give it a try

@ascripcaru
Copy link
Contributor Author

@honzajavorek now the bastard version of node that fails without a good reason is 4. if you could give it a restart? if you like the approach I'm glad that I could help

@kylef
Copy link
Member

kylef commented Dec 16, 2015

I hit rebuilt and it's passing now, not sure what's flaky with it.

@@ -1,11 +1,14 @@
sudo: required
dist: trusty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ascripcaru Hi, why are we locking build to some particular Ubuntu release here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@netmilk See my comment here: #310 (comment) it's basically the new image on Travis CI that has modern compilers. The default is much older.

netmilk pushed a commit that referenced this pull request Dec 17, 2015
Travis build with node 4 and 5
@netmilk netmilk merged commit 00e98f8 into apiaryio:master Dec 17, 2015
@netmilk netmilk mentioned this pull request Dec 19, 2015
artem-zakharchenko pushed a commit that referenced this pull request Oct 9, 2019
…config-airbnb-base-13.2.0

chore(deps-dev): update eslint-config-airbnb-base requirement from 13.1.0 to 13.2.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants