-
Notifications
You must be signed in to change notification settings - Fork 280
Conversation
This is awesome! Can't wait! 🎁 |
- ubuntu-toolchain-r-test | ||
packages: | ||
- gcc-4.8 | ||
- g++-4.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would be better to instead use the trusty image on Travis (https://docs.travis-ci.com/user/trusty-ci-environment/). Since it already has modern compilers it should speed up the CI time and also removes many lines from the .travis.yml file.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll give it a try
@honzajavorek now the bastard version of node that fails without a good reason is 4. if you could give it a restart? if you like the approach I'm glad that I could help |
I hit rebuilt and it's passing now, not sure what's flaky with it. |
@@ -1,11 +1,14 @@ | |||
sudo: required | |||
dist: trusty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ascripcaru Hi, why are we locking build to some particular Ubuntu release here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@netmilk See my comment here: #310 (comment) it's basically the new image on Travis CI that has modern compilers. The default is much older.
Travis build with node 4 and 5
…config-airbnb-base-13.2.0 chore(deps-dev): update eslint-config-airbnb-base requirement from 13.1.0 to 13.2.0
No description provided.