-
Notifications
You must be signed in to change notification settings - Fork 22
test: introduces custom chai assertions #204
Conversation
Experienced #139, restarting the build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18ecea6
to
cbfb18c
Compare
I still would like to provide errors assertions as a part of this pull request, just to make it clear. Focusing on them now. |
I think it is completely okay to merge this now and add them in a separate PR, but up to you. |
Custom assertions for the errors were also added, so the pull request should be complete! I ditched an idea to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
🎉 This PR is included in version 6.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
These changes introduce custom Chai assertions to use in Gavel unit and integration tests.
Motivation
chai
chainable operators. Common assertions include:GitHub
Roadmap
expect
instead ofassert
for better readability of custom assertionsConsider usingto.not.have.validator
as a replacement for.to.have.validator(null)