-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
@@ -0,0 +1,11 @@ | |||
const { parse } = require('jju/lib/parse'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only utils.js
relies on fs
. parse
module should be working fine in isolation, getting rid of fs
dependency, comparing when importing the module entirely:
const jju = require('jju')
6acb824
to
a44852a
Compare
@@ -0,0 +1,11 @@ | |||
const { parse } = require('jju/lib/parse'); | |||
|
|||
const parseJson = (json, revivew) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good idea in to have a wrapper not only because of the fs
issue, but also because in the past it happened already that we were switching the JSON parser implementations.
a44852a
to
1be13b5
Compare
1be13b5
to
abfcbd8
Compare
CI for PR failed due to the flaky test (#139). Restart should resolve the build status. |
1417868
to
ea5b7bf
Compare
ea5b7bf
to
e165a7f
Compare
🎉 This PR is included in version 7.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Prepares
gavel
to be used in the Core app.Changes
json-parse-helpfulerror
dependencymochify
andsinon
dev dependenciestest:browser
pipelinejju
save dependencyparseJson
utility wrapper aroundjju.parse()
to stop relying onfs
Adds test suite that ensuresgavel
can be bundled in the browsergavel
library intoCJSUMDGitHub