Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Reviving the Gavel.js package #74

Merged
merged 14 commits into from
Aug 10, 2016
Merged

Reviving the Gavel.js package #74

merged 14 commits into from
Aug 10, 2016

Conversation

honzajavorek
Copy link
Contributor

@honzajavorek honzajavorek commented Aug 8, 2016 •
edited
Loading

Also:

  • Fixes broken Cucumber test suite. Now all Cucumber tests run again. Not sure how to prevent this (skipping all the tests with exit status 0) to happen again.

@netmilk
Copy link
Contributor

netmilk commented Aug 9, 2016

@honzajavorek Ping me when it's green :)

@honzajavorek
test: Fixes Cucumber test suite
48eb27a 
The Cucumber test suite was accidentally skipping all the tests. It always
marked all tests as 'undefined' and returned exit status 0, which caused we
didn't notice it. I pluged in all the tests and got a lot of errors from recent
Cucumber upgrade in 51ab3eb. In attempt to
resolve the errors I made a lot of changes also to how the tests are written,
fixed several linter errors and other issues. Sorry for squashing all
the changes into one huge commit.
@honzajavorek
chore: Update of ignores
13ec1d3
@honzajavorek
chore: Removed unused dependency and using cross-platform cucumber-js
e43d6e9
@honzajavorek
chore: Semantic Release ✨
56924ed
@honzajavorek
Copy link
Contributor Author

@netmilk 💚 💚 💚

@honzajavorek honzajavorek mentioned this pull request Aug 10, 2016
Closed
@netmilk netmilk merged commit b1c484a into master Aug 10, 2016
@XVincentX XVincentX deleted the honzajavorek/revive branch August 10, 2016 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honzajavorek @netmilk