-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding helpers for asserting database query count #208
Adding helpers for asserting database query count #208
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.x #208 +/- ##
==========================================
+ Coverage 3.42% 5.13% +1.70%
- Complexity 659 677 +18
==========================================
Files 99 100 +1
Lines 2713 2767 +54
==========================================
+ Hits 93 142 +49
- Misses 2620 2625 +5 ☔ View full report in Codecov by Sentry. |
@Mohammad-Alavi Any ideas how I can add tests for the trait? |
@Mohammad-Alavi I have excluded the test traits from code coverage. I dont think it makes sense to specifically test test case helper traits. |
@yalsicor I think the traits should be tested in the Core. I have prepared the test file for your code to help you kickstart writing the tests for your new features. |
@Mohammad-Alavi I have added the tests and fixed some issues with my code. I have removed the Let me know what you think. |
Description
Dealing with performance and scaling issues due to poorly designed code logic can cause a lot of hard to pin problems, especially in bigger projects. This PR adds some helpers to give the tools during development and in tests to check for hidden N+1 problems.
This PR adds the documentation for the functionality.
Type of change