feat: useStarknet hook returns errors

apibara · Feb 4, 2022 · bb0084a · bb0084a
1 parent 89aee8e
commit bb0084a
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 5 deletions.
diff --git a/.changeset/neat-actors-play.md b/.changeset/neat-actors-play.md
@@ -0,0 +1,5 @@
+---
+'@starknet-react/core': minor
+---
+
+useStarknet hook now returns an error on activation
diff --git a/packages/core/src/providers/starknet/manager.ts b/packages/core/src/providers/starknet/manager.ts
@@ -7,6 +7,7 @@ import { StarknetState } from './model'
 interface StarknetManagerState {
   account?: string
   library: ProviderInterface
+  error?: string
 }
 
 interface SetAccount {
@@ -19,7 +20,12 @@ interface SetProvider {
   provider: ProviderInterface
 }
 
-type Action = SetAccount | SetProvider
+interface SetError {
+  type: 'set_error'
+  error: string
+}
+
+type Action = SetAccount | SetProvider | SetError
 
 function reducer(state: StarknetManagerState, action: Action): StarknetManagerState {
   switch (action.type) {
@@ -29,6 +35,9 @@ function reducer(state: StarknetManagerState, action: Action): StarknetManagerSt
     case 'set_provider': {
       return { ...state, library: action.provider }
     }
+    case 'set_error': {
+      return { ...state, error: action.error }
+    }
     default: {
       return state
     }
@@ -41,7 +50,7 @@ export function useStarknetManager(): StarknetState {
     library: defaultProvider,
   })
 
-  const { account, library } = state
+  const { account, library, error } = state
 
   useEffect(() => {
     if (typeof window !== undefined) {
@@ -63,9 +72,9 @@ export function useStarknetManager(): StarknetState {
       }
     } catch (err) {
       console.error(err)
-      // TODO: display error message to user
+      dispatch({ type: 'set_error', error: 'could not activate StarkNet' })
     }
   }, [])
 
-  return { account, hasStarknet, connectBrowserWallet, library }
+  return { account, hasStarknet, connectBrowserWallet, library, error }
 }
diff --git a/packages/core/src/providers/starknet/model.ts b/packages/core/src/providers/starknet/model.ts
@@ -5,6 +5,7 @@ export interface StarknetState {
   hasStarknet: boolean
   connectBrowserWallet: () => void
   library: ProviderInterface
+  error?: string
 }
 
 export const STARKNET_INITIAL_STATE: StarknetState = {

diff --git a/packages/core/test/providers/block.test.tsx b/packages/core/test/providers/block.test.tsx
@@ -11,7 +11,8 @@ describe('useStarknetBlock', () => {
     )
     const { result, waitForNextUpdate } = renderHook(() => useStarknetBlock(), { wrapper })
     expect(result.current).toBeUndefined()
-    await waitForNextUpdate()
+    // wait up to one minute for a block
+    await waitForNextUpdate({ timeout: 60000 })
     expect(result.current.timestamp).toBeGreaterThan(0)
     expect(result.current.block_hash).not.toBeUndefined()
   })

diff --git a/packages/core/test/providers/starknet.test.tsx b/packages/core/test/providers/starknet.test.tsx
@@ -0,0 +1,13 @@
+import React from 'react'
+import { renderHook } from '@testing-library/react-hooks'
+import { useStarknet, StarknetProvider } from '../../src'
+
+describe('useStarknetBlock', () => {
+  it('returns the current block', async () => {
+    const wrapper = ({ children }) => <StarknetProvider>{children}</StarknetProvider>
+    const { result } = renderHook(() => useStarknet(), { wrapper })
+    const { account, hasStarknet } = result.current
+    expect(account).toBeUndefined()
+    expect(hasStarknet).toBeFalsy()
+  })
+})