feat: disconnect #84
Merged
feat: disconnect #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
commented
Apr 28, 2022
| throw new UserNotConnectedError() | ||
| } | ||
|
|
||
| starknet.off('accountsChanged', () => {}) |
There was a problem hiding this comment.
@janek26 is this the expected way to disconnect a connected Argent account?
There was a problem hiding this comment.
this is entirely up to the dapp. Connection status is not stored in Argent X, but just in the wallet.
In get-starknet we handle it like this: https://github.com/starknet-community-libs/get-starknet/blob/master/src/index.ts#L92
There was a problem hiding this comment.
Thanks for sharing! I'll defer to maintainers then
|
Hmm the test failure appears not related to this PR It looks like getting block is taking too long. I bumped the timeout to 15s locally and a handful of test runs are now succeeding. |
|
Looks good! Can you add a changeset with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79