Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code generator for HTTP4S 0.18 with cats.effect.IO #280

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Conversation

aksharp
Copy link
Contributor

@aksharp aksharp commented Nov 9, 2017

In separate package to reduce conditional complexity but does result in some duplicate code

In separate package to reduce conditional complexity but does result in some duplicate code
Copy link
Collaborator

@mbryzek mbryzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aksharp aksharp merged commit 3fc30de into master Nov 9, 2017
@aksharp aksharp deleted the http4s_0_18 branch November 9, 2017 04:17
@gheine
Copy link
Collaborator

gheine commented Nov 9, 2017

Would be nice if we can reuse as much of the existing http4s generator code as possible, rather than duplicating the entire generator codebase.

@fabiocognigni
Copy link
Contributor

fabiocognigni commented Nov 10, 2017

+1 on reusing as more code as possible across different versions (same as it's been so far for 0.17 and below versions): working on #276 and #277 would require me coding the same enhancement on each version.

anadoba pushed a commit to anadoba/apibuilder-generator that referenced this pull request Mar 14, 2019
In separate package to reduce conditional complexity but does result in some duplicate code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants