Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a request decorator #422

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jlogeart
Copy link
Collaborator

Goal is to allow users to modify the request being issued.

Typical use case includes:

generatedClient.get(_.withRequestTimeout(2.seconds).withFollowRedirects(true))

@mbryzek
Copy link
Collaborator

mbryzek commented May 31, 2018

looks fine - curious if you considered doing this as an implicit to keep out ofarg list (but fine as consistent with other parameters there)

@jlogeart
Copy link
Collaborator Author

I briefly thought about and was not convinced that this kind of decorator should be implicit. I do not have a strong opinion about it all so if we think it is better as an implicit, I will happily add it to the implicit args.

@jlogeart jlogeart closed this May 31, 2018
@jlogeart jlogeart reopened this May 31, 2018
@mbryzek mbryzek requested a review from gheine May 31, 2018 18:29
@mbryzek
Copy link
Collaborator

mbryzek commented May 31, 2018

i've no strong opinion - gregor?

@gheine
Copy link
Collaborator

gheine commented May 31, 2018

LGTM. Is there a risk of breaking binary compatibility? Anyhow, would be nice to make the same change in the http4s generators.

@jlogeart
Copy link
Collaborator Author

http4s and ning are part of the PR.

This does break binary compatibility as the signatures are changed. There is no way around it as an "older" version of the class could always be loaded that does not contain the updated feature.

@gheine How do we go about it?

Copy link
Collaborator

@mbryzek mbryzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from master to main March 23, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants