Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update architecture diagrams with consistent naming and simplified labels #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vancura
Copy link
Collaborator

@vancura vancura commented Feb 21, 2025

This PR updates both horizontal and vertical architecture diagrams to improve consistency and readability:

Changes

  • Updated actor name from bob/screenshot to bob/screenshotter
  • Changed domain from .apify.actor to .apify.com in URLs
  • Simplified HTTP labels (removed "REQUEST AND RESPONSE" and "NOTIFICATION" suffixes)
  • Removed redundant port :443 from Web server component
  • Updated JSON property name from screenshotURL to screenshotUrl

Files changed

  • horizontal-diagram.png
  • vertical-diagram.png

Related

Fixes #104

@jancurn
Copy link
Member

jancurn commented Feb 21, 2025

Thanks Vaclav. The URL was supposed to be https://bob-screenshotter.apify.actor, sorry for the mistake. And please can the arrow to the web server be just unidirectional, to make it more clear?

And lastly, pls can we add the source code of the diagrams to the GitHub repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request top-priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update architecture diagram: domain, labels and port simplification
2 participants