Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes & improvements #52

Merged
merged 4 commits into from
Nov 11, 2024
Merged

small fixes & improvements #52

merged 4 commits into from
Nov 11, 2024

Conversation

TC-MO
Copy link
Contributor

@TC-MO TC-MO commented Nov 7, 2024

removed all unnecessary double spaces & trailing spaces
small rephrasings for better clarity
typo fixes

remmoved all unnecessary double spaces & trailing spaces
small rephrasings for better clarity
typo fixes
@TC-MO TC-MO requested a review from jancurn November 7, 2024 11:26
@TC-MO
Copy link
Contributor Author

TC-MO commented Nov 7, 2024

also the link to live-view-web-server seems to be leading to nowhere?

Copy link
Member

@jancurn jancurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the polishing

README.md Outdated

### Input

Each Actor accepts an **input object**, which tells it what it should do.
Each Actor accepts an **input object**, which specifies its operation parameters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep the old version, it's more specific

README.md Outdated
@@ -1252,7 +1238,7 @@ or to run an arbitrary web app.
The port on which the Actor can launch the web server
is specified by the `ACTOR_WEB_SERVER_PORT` environment variable.

The web server is started, it is exposed to the public internet on a **live view URL** identified
The web server is started, it is exposed to the public internet on a **live view URL** identified
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be: Once the web server is started ...

TC-MO and others added 2 commits November 8, 2024 19:39
fix another typo
remove remaining trailing spaces
@TC-MO TC-MO requested a review from jancurn November 11, 2024 17:13
README.md Outdated
- [Sharing and publishing](#sharing-and-publishing)
* [Monetization](#monetization)
- [Future work](#future-work)
- [The Web Actor Programming Model Whitepaper \[DRAFT\]](#the-web-actor-programming-model-whitepaper-draft)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use npm run build-toc for this, to limit the dept

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, one of my .md extension autogenerated toc, and I did not notice it

@jancurn jancurn merged commit 61674da into master Nov 11, 2024
1 check passed
@jancurn
Copy link
Member

jancurn commented Nov 11, 2024

@TC-MO thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants