Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing the TODOs #53

Merged
merged 15 commits into from
Nov 22, 2024
Merged

Addressing the TODOs #53

merged 15 commits into from
Nov 22, 2024

Conversation

netmilk
Copy link
Contributor

@netmilk netmilk commented Nov 20, 2024

  • Monetization Python and CLI examples
  • Local Development
  • Actorization Example (curl)

@netmilk netmilk marked this pull request as ready for review November 21, 2024 16:55
@netmilk netmilk requested review from jancurn and TC-MO November 21, 2024 16:55
jancurn
jancurn approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@jancurn jancurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just tiny comments, thanks

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
janbuchar
janbuchar approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netmilk
Copy link
Contributor Author

netmilk commented Nov 22, 2024

Perfect. I addressed all the comments. If you think it's OK to merge, let's do it, please.

@jancurn jancurn merged commit bf687b1 into master Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancurn jancurn jancurn approved these changes

@janbuchar janbuchar janbuchar approved these changes

@TC-MO TC-MO Awaiting requested review from TC-MO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netmilk @janbuchar @jancurn