Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Chromedriver compatibility issue in Python-Selenium #114

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Fix Chromedriver compatibility issue in Python-Selenium #114

merged 3 commits into from
Oct 18, 2023

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Oct 18, 2023

Closes #113

@github-actions github-actions bot added this to the 74nd sprint - Tooling team milestone Oct 18, 2023
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 18, 2023
@vdusek vdusek requested a review from fnesveda October 18, 2023 08:51
fnesveda
fnesveda requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Just one suggestion for the URL fetching

python-selenium/Dockerfile Outdated Show resolved Hide resolved
python-selenium/Dockerfile Outdated Show resolved Hide resolved
@vdusek vdusek requested a review from fnesveda October 18, 2023 13:25
fnesveda
fnesveda approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@vdusek vdusek merged commit b04fd53 into master Oct 18, 2023
27 checks passed
@vdusek vdusek deleted the fix-selenium branch October 18, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnesveda fnesveda fnesveda approved these changes

Assignees

@vdusek vdusek

Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
74nd sprint - Tooling team
Development

Successfully merging this pull request may close these issues.

Fix Chromedriver compatibility issue in Python-Selenium
2 participants
@vdusek @fnesveda