Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-purge to apify run #373

Closed
B4nan opened this issue Jun 7, 2023 · 0 comments · Fixed by #475
Closed

Add --no-purge to apify run #373

B4nan opened this issue Jun 7, 2023 · 0 comments · Fixed by #475
Assignees
Labels
t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@B4nan
Copy link
Member

B4nan commented Jun 7, 2023

With SDK v3 and crawlee, we now purge default storages automatically, and the purging is handled in crawlee (or better say in the storage client currently in use), so we just need to forward the right env vars and let crawlee do the job.

https://github.com/apify/crawlee/blob/master/packages/cli/src/commands/RunProjectCommand.ts#L33-L35

We should also clean up the old purging logic, it is not valid for v3 anymore, but a (rather confusing) warning can be still printed if the storage folder exists (confusing, as crawlee will wipe it automatically).

The CLI needs to keep working with new and old projects.

For easier use, we could have --resurrect alias for --no-purge.

@mtrunkat mtrunkat added the t-tooling Issues with this label are in the ownership of the tooling team. label Jun 13, 2023
vladfrangu added a commit that referenced this issue Feb 8, 2024
This has been a pain and a half to work in, especially because no TS 😢
but that'll change soon 😏

Also adds in proper migration support to custom folders instead of a
hardcoded folder for storages, full redirect of storages based on ENV
variables, and a base for detecting old apify-based actors (who knows,
maybe it'll be useful in the future)

Closes #373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants