-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage isn't purged for non-crawlee Apify SDKv3 projects #535
Comments
Hmm, but with sdk v3 you should get the purge by default anyway, or not? |
that's what i thought |
I see, @vladfrangu do you remember why it's like that? Feel's wrong, I'd say we should remove that line. It looks like now when you use the Apify CLI, it won't purge stuff by default even for crawlee projects and will require explicit |
Maybe better to keep those changes for the upcoming v1 release as they are indeed breaking and could surprise users if it currently works in the opposite way as it should. edit: on the other hand, we broke it just with the latest version ~month ago... |
This is edging undefined behavior terrain very fast. I also don't see why pre-crawlee should be purge opt-in but post-crawlee should be purging opt-out. I'd say lets clean up all of this logic in v1 (including for older sdks) -> always purge, opt out only. What I tried with that PR (but missed this case, which is easy to fix actually) is to make the crawlee behavior also opt in, like for old sdk. |
Because that's what we changed on purpose with v3. In v2 you had to use the CLI to purge, with v3 we purge by default, and we wanted to keep that behavior as changing it is breaking.
Yeah, that might be a good approach for v1. Thoughts @mvolfik? |
If the |
Nonetheless, unless the 1.0 is next week, can you please fix the original issue of this thread for 0.19? thanks |
Yeah, and that's the root of the problem, people in Apify are used to this while newcomers are confused by it. @vladfrangu let's fix this in v0.19 too please
How often do you actually want this behavior? I would say you want this only when testing resurrection of an actor, otherwise never? Which was one of the reasons we did the behaviour switch in the first place. |
@mvolfik 0.19.3 is out, let us know how it works |
Closing as the fix is now also in the master branch. |
I have a project using
"apify": "^3.1.0"
inpackage.json
, but I don't specify any Crawlee packages directly. However, in my code, I useActor.openKeyValueStore()
& friends. However, now the project is not detected asCRAWLEE
, nor asPRE_CRAWLEE_APIFY_SDK
, so no storage purge happens withrun -p
This is the section of the
0.19.1..0.19.2
diff that broke it, this is from PR #475The text was updated successfully, but these errors were encountered: