-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: print path to invalid actor.json
when an invalid file is found
#618
fix: print path to invalid actor.json
when an invalid file is found
#618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some test would be nice, i wonder how much time it takes to write the specs for this in cucumber so it would clearly show the output with the error? if its more than an hour, i wouldn't bother with that for this small thing though
or at least add a screenshot to the PR description showing the error in action
@B4nan I've added an image to the PR description. I'll also look into the cucumber test case, it should be easy enough |
``` | ||
- Then I can read text on stderr: | ||
``` | ||
Failed to read local config at path: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder if this can contain some wildcards so we could also assert a part of the path too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can contain anything we want it to contain, we'd just need to parse it in the handler for this matcher. I'd probably leave that for another PR unless you'd prefer it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all right, we can keep this for later, but i can imagine this will be important in other places
Invalid actor.jsons will have their path printed out now
Closes #561