Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/commands/actors/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { ApifyCommand } from '../../lib/apify_command.js';

export class ActorIndexCommand extends ApifyCommand<typeof ActorIndexCommand> {
static override description = 'Commands are designed to be used with Actors.';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an override, I guess it'll get glued to something else before printing to the console? On its own, the wording would be kinda weird.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, its printed when you run apify actors alone

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what's the exact thing that gets printed in that case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code - 2024-09-06 at 13 45 59@2x

When you have commands those get listed too

Code - 2024-09-06 at 13 46 29@2x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, thanks. Then I'd probably reword those descriptions along the lines of "Commands for working with Actors" or "for management of Actors"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats more of a @netmilk task, I just did what we did for other namespaces. Agreed it could use better copies but I wouldn't wanna block feature implementation just bc of that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it, but if we don't do it now, there will always be something more pressing than changing wording.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but that can hopefully be done in parallel by Adam 👀. This also ties into @barjin's comments on #620 about wording tbh, we definitely need a pass on all wording and improve it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made #637 to track this


async run() {
await this.printHelp();
}
}
9 changes: 9 additions & 0 deletions src/commands/datasets/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { ApifyCommand } from '../../lib/apify_command.js';

export class DatasetsIndexCommand extends ApifyCommand<typeof DatasetsIndexCommand> {
static override description = 'Commands are designed to be used with Datasets.';

async run() {
await this.printHelp();
}
}
9 changes: 9 additions & 0 deletions src/commands/key-value-stores/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { ApifyCommand } from '../../lib/apify_command.js';

export class KeyValueStoresIndexCommand extends ApifyCommand<typeof KeyValueStoresIndexCommand> {
static override description = 'Commands are designed to be used with Key Value Stores.';

async run() {
await this.printHelp();
}
}
9 changes: 9 additions & 0 deletions src/commands/request-queues/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { ApifyCommand } from '../../lib/apify_command.js';

export class RequestQueuesIndexCommand extends ApifyCommand<typeof RequestQueuesIndexCommand> {
static override description = 'Commands are designed to be used with Request Queues.';

async run() {
await this.printHelp();
}
}
9 changes: 9 additions & 0 deletions src/commands/runs/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { ApifyCommand } from '../../lib/apify_command.js';

export class RunsIndexCommand extends ApifyCommand<typeof RunsIndexCommand> {
static override description = 'Commands are designed to be used with Actor Runs.';

async run() {
await this.printHelp();
}
}
Loading