-
Notifications
You must be signed in to change notification settings - Fork 33
feat: bootstrap new command namespaces #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { ApifyCommand } from '../../lib/apify_command.js'; | ||
|
||
export class ActorIndexCommand extends ApifyCommand<typeof ActorIndexCommand> { | ||
static override description = 'Commands are designed to be used with Actors.'; | ||
|
||
async run() { | ||
await this.printHelp(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { ApifyCommand } from '../../lib/apify_command.js'; | ||
|
||
export class DatasetsIndexCommand extends ApifyCommand<typeof DatasetsIndexCommand> { | ||
static override description = 'Commands are designed to be used with Datasets.'; | ||
|
||
async run() { | ||
await this.printHelp(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { ApifyCommand } from '../../lib/apify_command.js'; | ||
|
||
export class KeyValueStoresIndexCommand extends ApifyCommand<typeof KeyValueStoresIndexCommand> { | ||
static override description = 'Commands are designed to be used with Key Value Stores.'; | ||
|
||
async run() { | ||
await this.printHelp(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { ApifyCommand } from '../../lib/apify_command.js'; | ||
|
||
export class RequestQueuesIndexCommand extends ApifyCommand<typeof RequestQueuesIndexCommand> { | ||
static override description = 'Commands are designed to be used with Request Queues.'; | ||
|
||
async run() { | ||
await this.printHelp(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { ApifyCommand } from '../../lib/apify_command.js'; | ||
|
||
export class RunsIndexCommand extends ApifyCommand<typeof RunsIndexCommand> { | ||
static override description = 'Commands are designed to be used with Actor Runs.'; | ||
|
||
async run() { | ||
await this.printHelp(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is an override, I guess it'll get glued to something else before printing to the console? On its own, the wording would be kinda weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, its printed when you run
apify actors
aloneThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what's the exact thing that gets printed in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you have commands those get listed too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thanks. Then I'd probably reword those descriptions along the lines of "Commands for working with Actors" or "for management of Actors"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats more of a @netmilk task, I just did what we did for other namespaces. Agreed it could use better copies but I wouldn't wanna block feature implementation just bc of that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get it, but if we don't do it now, there will always be something more pressing than changing wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but that can hopefully be done in parallel by Adam 👀. This also ties into @barjin's comments on #620 about wording tbh, we definitely need a pass on all wording and improve it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made #637 to track this