Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scrapy wrapping being broken due to ESM migration #686

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: scrapy wrapping being broken due to ESM migration #686

merged 1 commit into from
Oct 25, 2024

Conversation

vladfrangu
Copy link
Member

No description provided.

@vladfrangu vladfrangu added the adhoc Ad-hoc unplanned task added during the sprint. label Oct 25, 2024
@github-actions github-actions bot added this to the 101st sprint - Tooling team milestone Oct 25, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 25, 2024
B4nan
B4nan approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, how did you find out about this, discord?

asking because I am curious if people use this feature

it sucks that this (using __dirname in ESM project) won't fail the compilation

@vladfrangu
Copy link
Member Author

@vdusek actually just DM'd me about this. And yeah, because they are declared as globals, they are always present 😢. Probably can setup an eslint rule for this tho

vdusek
vdusek approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@vladfrangu vladfrangu merged commit e2a7591 into master Oct 25, 2024
19 checks passed
@vladfrangu vladfrangu deleted the fix/scrapy-wrapper branch October 25, 2024 10:01
vladfrangu added a commit that referenced this pull request Oct 25, 2024
@vladfrangu
fix: scrapy wrapping being broken due to ESM migration (#686)
7c9646b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

@B4nan B4nan B4nan approved these changes

Assignees

@vladfrangu vladfrangu

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
101st sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
3 participants
@vladfrangu @B4nan @vdusek