Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle stdin correctly from slower stdout emitting #704

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

vladfrangu
Copy link
Member

This works now

Code - 2024-11-21 at 20 17 11

@vladfrangu vladfrangu added the adhoc Ad-hoc unplanned task added during the sprint. label Nov 21, 2024
@vladfrangu vladfrangu requested a review from B4nan as a code owner November 21, 2024 18:19
@github-actions github-actions bot added this to the 103rd sprint - Tooling team milestone Nov 21, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 21, 2024
@vladfrangu vladfrangu enabled auto-merge (squash) November 21, 2024 18:21
package.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Nov 25, 2024
@vladfrangu vladfrangu requested a review from B4nan November 25, 2024 11:06
@@ -106,6 +106,7 @@ export class RunCommand extends ApifyCommand<typeof RunCommand> {
};

async run() {
console.log('running');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this one was only for debugging and shouldn't be here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOPS, indeed

await RunCommand.run([], import.meta.url);

console.log('ran');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@vladfrangu vladfrangu merged commit a5b53de into master Nov 25, 2024
17 checks passed
@vladfrangu vladfrangu deleted the fix/handle-slow-stdin-correctly branch November 25, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants