-
Notifications
You must be signed in to change notification settings - Fork 38
chore(deps): update dependency @apify/eslint-config to v1 #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4132f24
chore(deps): update dependency @apify/eslint-config to v1
renovate[bot] 5ee5eef
chore: bump eslint and everything with it
vladfrangu 296dbbb
chore: group formatting and linting on renovate
vladfrangu 855bb8c
chore: eslint cleanup
vladfrangu 40fd7b2
chore: requested changes
vladfrangu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "[javascript]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[javascriptreact]": { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode" | ||
| }, | ||
| "[json]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[typescript]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[typescriptreact]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[jsonc]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[yaml]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[markdown]": { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
| "files.trimTrailingWhitespace": false | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| import prettier from 'eslint-config-prettier'; | ||
| import tsEslint from 'typescript-eslint'; | ||
|
|
||
| // eslint-disable-next-line import/extensions -- todo: the import/extensions rule should be replaced with something that can handle exports in a package.json | ||
| import apify from '@apify/eslint-config/ts'; | ||
|
|
||
| export default [ | ||
| { | ||
| ignores: [ | ||
| '**/dist', | ||
| 'node_modules', | ||
| 'coverage', | ||
| 'website/{build,.docusaurus}', | ||
| '**/*.d.ts', | ||
| 'test/tmp/**/*', | ||
| '.yarn/**/*', | ||
| ], | ||
| }, | ||
| ...apify, | ||
| prettier, | ||
| { | ||
| languageOptions: { | ||
| parser: tsEslint.parser, | ||
| parserOptions: { | ||
| project: 'tsconfig.eslint.json', | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| plugins: { | ||
| '@typescript-eslint': tsEslint.plugin, | ||
| }, | ||
| rules: { | ||
| 'no-use-before-define': 'off', | ||
| '@typescript-eslint/no-use-before-define': ['error', { functions: false }], | ||
|
|
||
| 'no-console': 'off', | ||
|
|
||
| 'no-param-reassign': 'off', | ||
| // We have env variables with _ in their name | ||
| 'no-underscore-dangle': 'off', | ||
|
|
||
| // we do default exports | ||
| // TODO: remove once moved to yargs | ||
| 'import/no-default-export': 'off', | ||
vladfrangu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| '@typescript-eslint/consistent-type-imports': [ | ||
| 'error', | ||
| { | ||
| disallowTypeAnnotations: false, | ||
| }, | ||
| ], | ||
| '@typescript-eslint/consistent-type-definitions': ['error', 'interface'], | ||
|
|
||
| // Not ideal, but we still use any for simplicity | ||
| '@typescript-eslint/no-explicit-any': 'off', | ||
|
|
||
| // '@typescript-eslint/array-type': 'error', | ||
| // '@typescript-eslint/no-empty-object-type': 'off', | ||
| }, | ||
| }, | ||
| { | ||
| files: ['website/**/*'], | ||
| rules: { | ||
| '@typescript-eslint/no-shadow': 'off', | ||
| 'no-console': 'off', | ||
| 'no-undef': 'off', | ||
| }, | ||
| }, | ||
| { | ||
| files: ['src/**/*'], | ||
| rules: { | ||
| 'no-console': 'off', | ||
| 'consistent-return': 'off', | ||
| }, | ||
| }, | ||
| ]; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.