Skip to content

Refactor retries in RequestQueueClient(Async).batch_add_requests #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Pijukatel opened this issue Apr 23, 2025 · 0 comments · Fixed by #391
Closed

Refactor retries in RequestQueueClient(Async).batch_add_requests #390

Pijukatel opened this issue Apr 23, 2025 · 0 comments · Fixed by #391
Assignees
@Pijukatel
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@Pijukatel
Copy link
Contributor

Currently the batch_add_requests method of RequestQueueClient(Async) is doing some retries based on the status code response, this seems to duplicate retries already happening in HttpClient, that is already retrying the requests as well.

The retries in RequestQueueClient(Async) seems unnecessary.
@Pijukatel Pijukatel added debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team. labels Apr 23, 2025
@Pijukatel Pijukatel self-assigned this Apr 23, 2025
This was referenced Apr 23, 2025
Merged
Merged
Pijukatel added a commit that referenced this issue May 1, 2025
@Pijukatel
refactor: Remove redundant retries from batch_add_requests (#391)
636dc52 
### Description

Remove retries from `batch_add_requests` (such retries already exist on
the http client level).
Add deprecation warnings when retires related arguments are used.
Align sync and async version to not ignore exceptions from the http
client.
Add tests.

### Issues

- Closes: #390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pijukatel Pijukatel

Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Remove redundant retries from batch_add_requests apify/apify-client-python
1 participant
@Pijukatel