Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Python course lesson about saving data #1205

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

feat: Python course lesson about saving data #1205

wants to merge 14 commits into from
+240 −6

Conversation

honzajavorek
Copy link
Collaborator

@honzajavorek honzajavorek commented Sep 11, 2024 •
edited
Loading

TODO

  • intro etc.
  • export to CSV
  • export to JSON
  • fix CI errors
  • exercises
  • polish the texts
  • lesson closing

@honzajavorek honzajavorek added the t-academy Issues related to Web Scraping and Apify academies. label Sep 11, 2024
@honzajavorek honzajavorek force-pushed the honzajavorek/py-saving-data branch 3 times, most recently from e1e5717 to 70d6d2c Compare September 12, 2024 12:14
@honzajavorek honzajavorek marked this pull request as ready for review September 12, 2024 12:31
metalwarrior665
metalwarrior665 reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@metalwarrior665 metalwarrior665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add Crawlee extension later?

@honzajavorek
Copy link
Collaborator Author

What do you mean by Crawlee extension? Similar to the JS course, I want to tackle crawling now and then show how this all can be simplified using Crawlee. Not sure yet at which point I'll introduce Crawlee exactly, in the JS course it takes 5 more lessons before Crawlee is mentioned. I'd like to keep the code simple enough so it's easy to follow and once it isn't, I'd bring Crawlee in.

@honzajavorek
Copy link
Collaborator Author

honzajavorek commented Sep 13, 2024 •
edited
Loading

More TODO:

  • fix filename= in code examples, should be title=
  • fix order of imports, keep them in subsequent order as they're added throughout the course (now Decimal is suddenly first... could be alphabetically, but imho that just adds unnecessary cognitive load)
  • rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalwarrior665 metalwarrior665 metalwarrior665 left review comments

@mnmkng mnmkng mnmkng approved these changes

@TC-MO TC-MO Awaiting requested review from TC-MO

@vdusek vdusek Awaiting requested review from vdusek

Assignees
No one assigned
Labels
t-academy Issues related to Web Scraping and Apify academies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@honzajavorek @mnmkng @metalwarrior665