feat: Python course lesson about getting links #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzajavorek
added
the
t-academy
honzajavorek
requested review from
mnmkng,
vdusek,
metalwarrior665 and
TC-MO
mnmkng
reviewed
Sep 16, 2024
Comment on lines
+150
to
+162
| Now let's put it all together: | ||
|
|
||
| ```py | ||
| import httpx | ||
| from bs4 import BeautifulSoup | ||
| from decimal import Decimal | ||
| import csv | ||
| import json | ||
|
|
||
| def download(url): | ||
| ... | ||
|
|
||
| def parse_product(product): |
There was a problem hiding this comment.
I think it's beneficial to use runnable examples when "putting it all together". When the student gets stuck, breaks their code and needs to get back on track, a copiable example helps do that.
It's also harder to test the code regularly when none of the examples are actually runnable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dared to include my favorite gif that dates back to ancient Apiary times with @netmilk.