Skip to content

Reconsider Actor.main for v2 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
janbuchar opened this issue Aug 15, 2024 · 1 comment · Fixed by #210
Closed

Reconsider Actor.main for v2 #237

janbuchar opened this issue Aug 15, 2024 · 1 comment · Fixed by #210
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Milestone
v2.0

Comments

@janbuchar
Copy link
Contributor

janbuchar commented Aug 15, 2024 •
edited
Loading

It could take care of asyncio.run for example, or it could be a decorator. There isn't much value in it now, compared to async with Actor.

A few mockups:

from apify import Actor

@Actor.main
async def main():
  Actor.push_data({})
from apify import Actor

async def main():
  Actor.push_data({})

Actor.run(main())
@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Aug 15, 2024
@janbuchar janbuchar added this to the v2.0 milestone Aug 15, 2024
@janbuchar
Copy link
Contributor Author

Let's just remove it

@vdusek vdusek mentioned this issue Aug 22, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

refactor!: Preparation for v2 release apify/apify-sdk-python
1 participant
@janbuchar