Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Preparation for v2 release #210

Merged
merged 69 commits into from
Aug 27, 2024
Merged

refactor!: Preparation for v2 release #210

merged 69 commits into from
Aug 27, 2024

Conversation

janbuchar
Copy link
Contributor

@janbuchar janbuchar commented Jun 4, 2024

  • Update pyproject.toml

  • Use storage code from crawlee, add ApifyStorageClient

  • make sure we use APIFY_IS_AT_HOME instead of token for all platform vs. local decisions

  • port over warnedAboutMissingInitCall from JS SDK (this is not exactly ported over, but we expect this won't happen frequently, so we just throw an exception)

Issues

@github-actions github-actions bot added this to the 91st sprint - Tooling team milestone Jun 4, 2024
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Jun 4, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@janbuchar janbuchar added the adhoc Ad-hoc unplanned task added during the sprint. label Jun 5, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

If issue is not linked to the pull request then estimate the pull request!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

If issue is not linked to the pull request then estimate the pull request!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

If issue is not linked to the pull request then estimate the pull request!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

If issue is not linked to the pull request then estimate the pull request!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

If issue is not linked to the pull request then estimate the pull request!

src/apify/event_manager.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last details...

src/apify/storages/__init__.py Outdated Show resolved Hide resolved
src/apify/storages/__init__.py Show resolved Hide resolved
src/apify/_utils.py Outdated Show resolved Hide resolved
@janbuchar janbuchar requested a review from vdusek August 27, 2024 14:40
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@janbuchar
Copy link
Contributor Author

image

@janbuchar janbuchar merged commit 2f9dcc5 into master Aug 27, 2024
19 checks passed
@janbuchar janbuchar deleted the v2 branch August 27, 2024 15:05
janbuchar added a commit that referenced this pull request Aug 28, 2024
The module was made private in #210, but it turns out it is actually
mentioned in the documentation, so we're keeping it public to make less
noise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
2 participants