-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Preparation for v2 release #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If issue is not linked to the pull request then estimate the pull request!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If issue is not linked to the pull request then estimate the pull request!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If issue is not linked to the pull request then estimate the pull request!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If issue is not linked to the pull request then estimate the pull request!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If issue is not linked to the pull request then estimate the pull request!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last details...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
The module was made private in #210, but it turns out it is actually mentioned in the documentation, so we're keeping it public to make less noise.
Update pyproject.toml
Use storage code from crawlee, add ApifyStorageClient
make sure we use
APIFY_IS_AT_HOME
instead of token for all platform vs. local decisionsport over
warnedAboutMissingInitCall
from JS SDK (this is not exactly ported over, but we expect this won't happen frequently, so we just throw an exception)Issues
consts.py
module from theapify-shared
#135Any
with generic types #138APIFY_DEFAULT_XXX_ID
env var inBaseResourceClient
#149Actor.main
for v2 #237