Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make apify.log public again #249

Merged
merged 3 commits into from
Aug 28, 2024
Merged

fix: Make apify.log public again #249

merged 3 commits into from
Aug 28, 2024

Conversation

janbuchar
Copy link
Contributor

@janbuchar janbuchar commented Aug 28, 2024 •
edited
Loading

The module was made private in #210, but it turns out it is actually mentioned in the documentation, so we're keeping it public to make less noise.

@janbuchar janbuchar added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Aug 28, 2024
@janbuchar janbuchar requested a review from vdusek August 28, 2024 09:56
@github-actions github-actions bot added this to the 97th sprint - Tooling team milestone Aug 28, 2024
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Aug 28, 2024
vdusek
vdusek approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbuchar janbuchar merged commit 22677f5 into master Aug 28, 2024
19 checks passed
@janbuchar janbuchar deleted the make-log-public-again branch August 28, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

@janbuchar janbuchar

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
97th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@janbuchar @vdusek