Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the rest unit tests for actor #40

Merged
merged 4 commits into from
Feb 2, 2023
Merged

feat: add the rest unit tests for actor #40

merged 4 commits into from
Feb 2, 2023

Conversation

drobnikj
Copy link
Member

@drobnikj drobnikj commented Jan 30, 2023 •
edited
Loading

I hope the last unit tests which missing for actor.

@github-actions github-actions bot added this to the 56th sprint - Platform team milestone Jan 30, 2023
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Jan 30, 2023
jirimoravcik
jirimoravcik approved these changes Jan 30, 2023
View reviewed changes
tests/unit/actor/test_actor_helpers.py Outdated
async def test_async_with_actor_properly_initialize(self) -> None:
async with Actor:
assert Actor._get_default_instance()._is_initialized
# TODO: More checks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

fnesveda
fnesveda requested changes Jan 31, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Only note is that I would keep it in two separate files, test_actor_lifecycle.py and test_actor_api_helpers.py, it's cleaner that way.

tests/unit/actor/test_actor_helpers.py Show resolved Hide resolved
tests/unit/actor/test_actor_helpers.py Outdated Show resolved Hide resolved
@drobnikj drobnikj mentioned this pull request Feb 1, 2023
Merged
1 task
drobnikj and others added 2 commits February 1, 2023 18:11
@drobnikj @fnesveda
Update tests/unit/actor/test_actor_helpers.py
ab1d35a 
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
@drobnikj
fix: review fixes
19972c9
@drobnikj drobnikj requested a review from fnesveda February 1, 2023 17:18
@drobnikj drobnikj merged commit 72d92ea into master Feb 2, 2023
@drobnikj drobnikj deleted the feat/missing_unit_tests branch February 2, 2023 08:01
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnesveda fnesveda fnesveda approved these changes

@jirimoravcik jirimoravcik jirimoravcik approved these changes

Assignees

@drobnikj drobnikj

Labels
t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
56th sprint - Platform team
Development

Successfully merging this pull request may close these issues.
3 participants
@drobnikj @jirimoravcik @fnesveda