Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input_schema): storage editor types #476

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

MFori
Copy link
Contributor

@MFori MFori commented Sep 12, 2024

This PR introduce new input schema editor values for string property:
dataset, keyValueStore and requestQueue based on issue: https://github.com/apify/apify-core/issues/12871

The editor will show storage inputs enabling users to search and select storage, then the storage id is taken as field value.
Input PR waiting for this: https://github.com/apify/apify-core/pull/17521
Docs PR: apify/apify-docs#1211

Screenshot 2024-09-12 at 8 34 00

@MFori MFori added the t-console Issues with this label are in the ownership of the console team. label Sep 12, 2024
@MFori MFori self-assigned this Sep 12, 2024
@github-actions github-actions bot added this to the 98th sprint - Console team milestone Sep 12, 2024
@MFori MFori marked this pull request as ready for review September 12, 2024 06:57
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Sep 13, 2024
@MFori MFori merged commit c9a4a9d into master Sep 13, 2024
9 checks passed
@MFori MFori deleted the feat/input-storage-types branch September 13, 2024 07:47
MFori added a commit to apify/apify-docs that referenced this pull request Oct 4, 2024
Add new input schema `editor` values for `string` properties to input
schema specification.
This is based on this issue:
apify/apify-core#12871 and part of
- Input schema PR: apify/apify-shared-js#476
- (app) Storage input PR:
apify/apify-core#12871

This one will be merged as the last one.

<img width="1347" alt="Screenshot 2024-09-12 at 8 47 10"
src="https://github.com/user-attachments/assets/04e5086b-770b-4171-a55d-b33d0305849c">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-console Issues with this label are in the ownership of the console team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants