fix: resolved an issue where types were not being properly picked up in some ESM TS projects (resolves #62) #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #62.
I found that this package was causing type errors in my application. The proposed solution is the least intrusive I have found. I considered overhauling the bundling pipeline altogether using something like Rollup. While it seems to be a better way of achieving ESM+CJS compatibility, it could present breaking changes and have all kinds of side effects, so I opted for patching package.json instead.
References:
https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/docs/problems/FalseCJS.md (In-Depth about "Masquerading as CJS" problem)
microsoft/TypeScript#52363 (comment) (TL;DR solution)