Validate storage names before passing them to the storage client

[vdusek]

The Apify platform has these limitations:

apify_client.errors.ApifyApiError: Invalid value provided in store: name can only contain letters 'a' through 'z', the digits '0' through '9', and the hyphen ('-') but only in the middle of the string (e.g. 'my-value-1')

We should validate and enforce this rule on the storage level - before passing it to the storage clients.

[Pijukatel]

Related to: #1354

I am not sure about validation at the storage level. This naming rule is specific to one client from the downstream repo. I think the constraint should be validated in that specific client

[vdusek]

Isn't that weird? I'd say storage names (and other attributes) should follow the same constraints regardless of the storage client being used. Otherwise, you could have a valid storage setup locally, but when deploying it to Apify, it might raise an error. I'd prefer to keep it consistent.

What do you think @B4nan?

[B4nan]

Yeah, definitely, while it sucks that the only real problem is the Apify platform imposing restrictions, we should keep those rules global, otherwise you would only find out about it once you try to deploy.

[B4nan]

@Mantisus please try to priotize this, its technically a small BC for people not targetting the apify platform, lets try to ship it later this week.

[Pijukatel]

Yeah, definitely, while it sucks that the only real problem is the Apify platform imposing restrictions, we should keep those rules global, otherwise you would only find out about it once you try to deploy.

I think the proper level is implementing it at the SDK level. This way it is not affecting other clients and it solves the problem of "otherwise you would only find out about it once you try to deploy."
https://github.com/apify/apify-sdk-python/tree/master/src/apify/storage_clients/_apify
https://github.com/apify/apify-sdk-python/tree/master/src/apify/storage_clients/_smart_apify

[B4nan]

Not sure I follow, you need the same restrictions during local development, what you suggest means using the Apify Client, so the API, so not local implementations, right?

edit: or that "smart apify client" is the "run things locally if not on platform" one? then I guess it sounds all right