-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CurlImpersonateHttpClient
warning on Windows
#495
Comments
@MrTyton Looks like you have to add |
I believe we should document this somewhere, follow-up issue is ok |
I'm not so sure about that, it's a limitation of a package that we integrate with and the warning tells you what to do pretty well. Maybe we can add a line about this into the docblock of |
This adds a unified `crawlee/project_template` template. The original `playwright` and `beautifulsoup` templates are kept for compatibility with older versions of the CLI. The user is now prompted for package manager type (pip, poetry), crawler type, start URL and whether or not Apify integration should be set up. - closes apify#317 - closes apify#414 (http client selection is not implemented) - closes apify#511 - closes apify#495 ### TODO - [x] http client selection - [x] disable poetry option if it isn't installed - [x] rectify the pip-based setup 1. **manual dependency installation** - no automatic installation, just dump requirements.txt and tell the user to handle it any way they want 2. **pip+venv** - dump requirements.txt, make a virtualenv (.venv) using the current python interpreter, install requirements and tell user to activate it - ~should be disabled if `venv` module is not present~ it's stdlib - [x] test the whole thing on Windows (mainly the various package manager configurations) - [x] fix how cookiecutter.json is read (it is not present when installing via pip)
Using the
CurlImpersonateHttpClient
adds this warning message upon program start, which doesn't seem to be fixed if I add in the command that it asks forOriginally posted by @MrTyton in #486 (comment)
The text was updated successfully, but these errors were encountered: