Skip to content

'RequestQueue._clear_possible_locks' is not handled correctly in event_manager #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mantisus opened this issue Dec 14, 2024 · 0 comments · Fixed by #825
Closed

'RequestQueue._clear_possible_locks' is not handled correctly in event_manager #815

Mantisus opened this issue Dec 14, 2024 · 0 comments · Fixed by #825
Assignees
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@Mantisus
Copy link
Collaborator

Mantisus commented Dec 14, 2024

When the Event.MIGRATING event occurs, we get an error

RuntimeWarning: coroutine 'RequestQueue._clear_possible_locks' was never awaited
  handle = None # Needed to break cycles when an exception occurs.
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

Due to incorrect listener initialization

event_manager.on(event=Event.MIGRATING, listener=lambda _: self._clear_possible_locks())
event_manager.on(event=Event.ABORTING, listener=lambda _: self._clear_possible_locks())

This fix is worth doing after #800, since _clear_possible_locks doesn't expect any parameters

@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Dec 14, 2024
@vdusek vdusek added the bug Something isn't working. label Dec 16, 2024
@vdusek vdusek added this to the 105th sprint - Tooling team milestone Dec 16, 2024
vdusek pushed a commit that referenced this issue Dec 17, 2024
### Description

- fix event migrating handler and `is_finished` method in `RequestQueue`

### Issues

- Closes: #815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants