fix: Remove tmp folder for PlaywrightCrawler in non-headless mode #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mantisus
requested review from
Pijukatel and
vdusek
and removed request for
vdusek
Pijukatel
reviewed
Mar 4, 2025
Collaborator
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
Could you please add tiny test for this scenario that checks that the dir exists and is deleted when close is called.
Mantisus
force-pushed
the
fix-remove-tmp-files
branch
2 times, most recently
from
83992a0 to
639c797
Compare
Mantisus
force-pushed
the
fix-remove-tmp-files
branch
from
639c797 to
479dd4c
Compare
Pijukatel
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closeevent, for when for some reason the browser crashes and the context is closed by the Playwright mechanisms